[291] Enable lint errcheck #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 53.90% // Head: 54.36% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
==========================================
+ Coverage 53.90% 54.36% +0.45%
==========================================
Files 345 369 +24
Lines 42685 42708 +23
Branches 599 599
==========================================
+ Hits 23011 23218 +207
+ Misses 17239 17028 -211
- Partials 2435 2462 +27
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ghost
suggested changes
Nov 16, 2022
dynamics/db_test.go
Outdated
| @@ -78,7 +81,7 @@ func TestGetSetNode(t *testing.T) { | |||
| db := initializeDB() | |||
|
|
|||
| node := &Node{} | |||
| db.rawDB.Update(func(txn *badger.Txn) error { | |||
| _ = db.rawDB.Update(func(txn *badger.Txn) error { | |||
dynamics/db_test.go
Outdated
| @@ -124,7 +127,7 @@ func TestGetSetLinkedList(t *testing.T) { | |||
| db := initializeDB() | |||
|
|
|||
| ll := &LinkedList{} | |||
| db.rawDB.Update(func(txn *badger.Txn) error { | |||
| _ = db.rawDB.Update(func(txn *badger.Txn) error { | |||
layer1/executor/model.go
Outdated
| @@ -135,7 +136,7 @@ type ManagerResponseInfo struct { | |||
| type requestStored struct { | |||
| BaseRequest | |||
| WrappedTask *marshaller.InstanceWrapper `json:"wrappedTask"` | |||
| killedAt uint64 `json:"killedAt"` | |||
| killedAt uint64 `json:"-"` | |||
There was a problem hiding this comment.
Should pull this out of the PR unless it's needed by another change.
layer1/executor/task_manager.go
Outdated
| @@ -121,7 +122,10 @@ func (tm *TaskManager) eventLoop() { | |||
|
|
|||
| case taskRequest, ok := <-tm.requestChan: | |||
| if !ok { | |||
| tm.onError(ErrReceivedRequestClosedChan) | |||
| err := tm.onError(ErrReceivedRequestClosedChan) | |||
There was a problem hiding this comment.
tm.onError always returns an error, no need to check if it's not nil. Probably can just _ this error.
pbains
force-pushed
the
pbains/291-lint-errcheck
branch
from
11d3c50
to
483ab98
Compare
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Why?
Code maintenance and readability
Todos
Keep the issue open because more linting needs to be completed before closing.