Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaned up comment block in AliceNetFactoryBase.sol #61

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

z-j-lin
Copy link
Contributor

@z-j-lin z-j-lin commented Jul 12, 2022

Scope

What is changing with this PR?

Why?

Why are we doing this?

Todos

If any, what are the follow-up tasks required other than merging this PR? Have they been arranged?

  • ???

@z-j-lin z-j-lin requested a review from vtleonardo July 12, 2022 19:46
@z-j-lin z-j-lin requested review from Cr0wn-Gh0ul and removed request for vtleonardo July 12, 2022 19:47
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #61 (2b78e1d) into main (ed48b7f) will increase coverage by 0.60%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   45.03%   45.63%   +0.60%     
==========================================
  Files         220      214       -6     
  Lines       40002    38484    -1518     
==========================================
- Hits        18016    17564     -452     
+ Misses      20023    18986    -1037     
+ Partials     1963     1934      -29     
Impacted Files Coverage Δ
utils/shared.go 56.36% <0.00%> (-26.31%) ⬇️
badgerTrie/smt_merkle_proof.go 60.93% <0.00%> (-2.35%) ⬇️
config/settings.go 0.00% <0.00%> (ø)
blockchain/objects/scheduler.go
blockchain/monitor/event_setup.go
blockchain/objects/state.go
blockchain/monitor/monitor.go
blockchain/objects/generic_marshaller.go
blockchain/cancellation.go
blockchain/tasks/snapshot_task.go
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed48b7f...2b78e1d. Read the comment docs.

Copy link
Contributor

@Cr0wn-Gh0ul Cr0wn-Gh0ul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment cleaned up.

@Cr0wn-Gh0ul Cr0wn-Gh0ul merged commit cb5caec into alicenet:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants