Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tool to remove hardhat console logs from contracts #96

Merged
1 commit merged into from
Jul 22, 2022

Conversation

vtleonardo
Copy link
Contributor

Scope

Added a hardhat plugin to automatically remove any console.log imports and usage in our smart contracts. The dev will need to run npm run build in other to make sure that the tool is executed.

@vtleonardo vtleonardo requested a review from a user July 22, 2022 12:38
@github-actions github-actions bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code solidity labels Jul 22, 2022
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #96 (8b4875c) into main (68726e4) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   48.94%   48.93%   -0.01%     
==========================================
  Files         287      287              
  Lines       42317    42317              
==========================================
- Hits        20712    20708       -4     
+ Misses      19252    19249       -3     
- Partials     2353     2360       +7     
Impacted Files Coverage Δ
badgerTrie/smt_merkle_proof.go 65.62% <0.00%> (-3.91%) ⬇️
peering/active.go 83.96% <0.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68726e4...8b4875c. Read the comment docs.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghost ghost merged commit ec1b539 into alicenet:main Jul 22, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code solidity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant