[Controls] Prevent the filter text field from being out of the window #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
force-pushed
the
fix/editChoiceParam
branch
2 times, most recently
from
d83e908
to
2349499
Compare
cbentejac
force-pushed
the
fix/editChoiceParam
branch
2 times, most recently
from
fb2644e
to
702868a
Compare
The filter text field is now always placed at the position of the attribute, meaning it is always in sight. The list of values is then either dropped downwards or opened upwards depending on its size and where there is the most free space.
Up until this commit, any action causing the filtering text field to lose the focus was considered to be a valid edition, thus propagating the value in the text field or the one highlighted to be propagated, even if the user was clicking anywhere else in the application, or pressing the `esc` key. The distinction is now made between cases where the edition is finished because it was validated (value clicked on, or selected with the `return`/ `enter` key), and not because it was cancelled (clicks outside of the combobox or `esc` key pressed).
cbentejac
force-pushed
the
fix/editChoiceParam
branch
from
24a511e
to
5eaec8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a UI issue that occurred for exclusive
ChoiceParamattributes with large lists: when the node editor's height is bigger than the default one, the popup with the list of values was positioned at the top of the attribute's field, and its filtering text field was positioned outside of the application window.The filtering text field is now always located at the attribute's place, meaning it can never be out of screen. The list of values is
then either dropped downwards or opened upwards depending on its size and where there is the most free space.
If we take the "Group Camera Fallback" attribute from the
CameraInitnode, instead of being displayed as such:The filtering field text now looks like this, with the direction of the list of values depending on whether there is enough room downwards or not: