Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing thrust include #135

Merged

Conversation

puzzlepaint
Copy link
Contributor

Adding this include was necessary to compile popsift in my environment (with CUDA release 11.4, V11.4.48).

@simogasp simogasp added the cuda issues related to cuda versions label Aug 30, 2021
@simogasp simogasp added this to the v1.0.0 milestone Aug 30, 2021
@simogasp simogasp self-assigned this Aug 30, 2021
Copy link
Member

@simogasp simogasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for your contribution!

@simogasp
Copy link
Member

Just for reference, here is the log to the compilation error with cuda 11.4

popsift/src/popsift/s_filtergrid.cu(204): error: namespace "thrust" has no member "host_vector"

popsift/src/popsift/s_filtergrid.cu(204): error: type name is not allowed

popsift/src/popsift/s_filtergrid.cu(204): error: identifier "h_cell_counts" is undefined

popsift/src/popsift/s_filtergrid.cu(205): error: namespace "thrust" has no member "host_vector"

popsift/src/popsift/s_filtergrid.cu(205): error: type name is not allowed

popsift/src/popsift/s_filtergrid.cu(205): error: identifier "h_cell_permute" is undefined

popsift/src/popsift/s_filtergrid.cu(206): error: namespace "thrust" has no member "host_vector"

popsift/src/popsift/s_filtergrid.cu(206): error: type name is not allowed

popsift/src/popsift/s_filtergrid.cu(206): error: identifier "h_cell_offsets" is undefined

popsift/src/popsift/s_filtergrid.cu(207): error: namespace "thrust" has no member "host_vector"

popsift/src/popsift/s_filtergrid.cu(207): error: type name is not allowed

popsift/src/popsift/s_filtergrid.cu(207): error: identifier "h_cell_limits" is undefined

popsift/src/popsift/s_filtergrid.cu(208): error: namespace "thrust" has no member "host_vector"

popsift/src/popsift/s_filtergrid.cu(208): error: type name is not allowed

popsift/src/popsift/s_filtergrid.cu(208): error: identifier "cell_count_prefix_sums" is undefined

popsift/src/popsift/s_filtergrid.cu(209): error: namespace "thrust" has no member "host_vector"

popsift/src/popsift/s_filtergrid.cu(209): error: type name is not allowed

popsift/src/popsift/s_filtergrid.cu(209): error: identifier "cell_count_sumup" is undefined

popsift/src/popsift/s_filtergrid.cu(230): error: namespace "thrust" has no member "host_vector"

popsift/src/popsift/s_filtergrid.cu(230): error: type name is not allowed

popsift/src/popsift/s_filtergrid.cu(230): error: identifier "h_reverse_index" is undefined

21 errors detected in the compilation of "popsift/src/popsift/s_filtergrid.cu".
CMake Error at popsift_generated_s_filtergrid.cu.o.Release.cmake:280 (message):
  Error generating file
  external/popsift_build/src/CMakeFiles/popsift.dir/popsift/./popsift_generated_s_filtergrid.cu.o

@simogasp simogasp merged commit 4c22d41 into alicevision:develop Aug 30, 2021
@puzzlepaint puzzlepaint deleted the fix_missing_thrust_include branch August 30, 2021 13:11
@simogasp simogasp modified the milestones: v1.0.0, v0.9.1 Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda issues related to cuda versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants