Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IsADirectory error upon reinstallation #246

Merged
merged 8 commits into from
Jan 27, 2020
Merged

Fix IsADirectory error upon reinstallation #246

merged 8 commits into from
Jan 27, 2020

Conversation

alichtman
Copy link
Owner

@alichtman alichtman commented Jan 27, 2020 •
edited
Loading

Fix #216.

Refactored from stale PR #243.

@alichtman
Copy link
Owner Author

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 1

See the complete overview on Codacy

@alichtman alichtman merged commit 49407a3 into master Jan 27, 2020
@alichtman alichtman deleted the fix_IsADirectoryError_upon_reinstallation branch January 27, 2020 23:08
@alichtman alichtman mentioned this pull request Jan 27, 2020
Closed
alichtman added a commit that referenced this pull request Mar 22, 2020
@alichtman @heysupratim
Fix IsADirectory error upon reinstallation (#246)
8ef63d8 
* Fixes #216

* Added Test Coverage for reinstallation of dotfiles regarding #216

* Refactor reinstallation code

Co-authored-by: Supratim <sup270792@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when reinstalling all
2 participants
@alichtman @heysupratim