Update formatter.rb #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An error occurred while running tests
|
Did the api change? If so, will you bump the minimum version on cucumber to the relevant version? |
|
Now we use cucumber - 2.4.0 |
|
|
What does it mean - "relevant version"? What shall I do? |
|
Update the gemspec with the minimum version needed for this code to work. As-is, your code would allow older version of cucumber which may not work. |
|
@Paradoxxal - I have updated all gems and all specs run fine. I don't see the need to change this, can you point me to an issue or source change that would require this change? Or provide a breaking spec that this fixes? |
|
I'm going to close this in favor of #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error occurred while running tests