Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the new formatter API #11

Open
rosskevin opened this issue Aug 11, 2016 · 3 comments
Open

Update to the new formatter API #11

rosskevin opened this issue Aug 11, 2016 · 3 comments

Comments

@rosskevin
Copy link
Member

@callahat discovered a new api for timing:

Turns out there is a new formatter api that should be used instead.

( Cuke group thread on google groups: https://groups.google.com/forum/#!topic/cukes/HIGakoahWEA )

Help wanted, please PR - this is a good/easy first enhancement (it appears).

@rosskevin
Copy link
Member Author

rosskevin commented Jun 20, 2018

This now appears to be a bug - broken in cucumber >= 3

undefined method `regexp_source' for #<Cucumber::Glue::StepDefinition:0x00007ffdfdc01428> (NoMethodError)
/Users/kross/.rvm/gems/ruby-2.5.1@archetype/gems/cucumber_statistics-2.3.0/lib/cucumber_statistics/formatter.rb:29:in `after_step_result'
/Users/kross/.rvm/gems/ruby-2.5.1@archetype/gems/cucumber-3.1.1/lib/cucumber/formatter/ignore_missing_messages.rb:11:in `method_missing'
/Users/kross/.rvm/gems/ruby-2.5.1@archetype/gems/cucumber-3.1.1/lib/cucumber/formatter/legacy_api/ast.rb:117:in `accept'
/Users/kross/.rvm/gems/ruby-2.5.1@archetype/gems/cucumber-3.1.1/lib/cucumber/formatter/legacy_api/adapter.rb:580:in `step_invocation'
/Users/kross/.rvm/gems/ruby-2.5.1@archetype/gems/cucumber-3.1.1/lib/cucumber/formatter/legacy_api/adapter.rb:543:in `step_invocation'
/Users/kross/.rvm/gems/ruby-2.5.1@archetype/gems/cucumber-3.1.1/lib/cucumber/formatter/legacy_api/adapter.rb:387:in `print_step'
/Users/kross/.rvm/gems/ruby-2.5.1@archetype/gems/cucumber-3.1.1/lib/cucumber/formatter/legacy_api/adapter.rb:251:in `after_test_step'
/Users/kross/.rvm/gems/ruby-2.5.1@archetype/gems/cucumber-3.1.1/lib/cucumber/formatter/legacy_api/adapter.rb:107:in `after_test_step'
/Users/kross/.rvm/gems/ruby-2.5.1@archetype/gems/cucumber-3.1.1/lib/cucumber/formatter/legacy_api/adapter.rb:31:in `block in initialize'
/Users/kross/.rvm/gems/ruby-2.5.1@archetype/gems/cucumber-core-3.1.0/lib/cucumber/core/event_bus.rb:34:in `block in broadcast'
/Users/kross/.rvm/gems/ruby-2.5.1@archetype/gems/cucumber-core-3.1.0/lib/cucumber/core/event_bus.rb:34:in `each'
/Users/kross/.rvm/gems/ruby-2.5.1@archetype/gems/cucumber-core-3.1.0/lib/cucumber/core/event_bus.rb:34:in `broadcast'
/Users/kross/.rvm/gems/ruby-2.5.1@archetype/gems/cucumber-core-3.1.0/lib/cucumber/core/event_bus.rb:40:in `method_missing'
/Users/kross/.rvm/gems/ruby-2.5.1@archetype/gems/cucumber-core-3.1.0/lib/cucumber/core/test/runner.rb:35:in `around_hook'
/Users/kross/.rvm/gems/ruby-2.5.1@archetype/gems/cucumber-core-3.1.0/lib/cucumber/core/test/around_hook.rb:12:in `describe_to'
/Users/kross/.rvm/gems/ruby-2.5.1@archetype/gems/cucumber-core-3.1.0/lib/cucumber/core/test/case.rb:120:in `block (2 levels) in compose_around_hooks'

@rosskevin rosskevin changed the title Update to the new formatter API Update to the new formatter API (broken in cucumber >= 3) Jun 20, 2018
@rosskevin rosskevin added bug and removed enhancement labels Jun 20, 2018
@rosskevin
Copy link
Member Author

Partial fix (not a new formatter api usage): #15

@rosskevin rosskevin changed the title Update to the new formatter API (broken in cucumber >= 3) Update to the new formatter API Jun 20, 2018
@rosskevin rosskevin added enhancement and removed bug labels Jun 20, 2018
@rosskevin
Copy link
Member Author

#15 and 3.0.0 gets us by for now, so updating to the new formatter is a nice to have enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant