-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve information about installing missing fonts in neateqn.ms #10
Open
mcctuxic
wants to merge
1
commit into
aligrudi:master
Choose a base branch
from
mcctuxic:fontfixindemo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcctuxic <notifications@github.com> wrote:
Added some informations for first time users of neatroff how to install and use some extra fonts for the documentation
Very good.
A few suggestions:
+ Copying the contents of afm and pfb folders are necessary and adequate.
+ It is better to use \(lq and \(rq instead of double quotes.
+ I think it is better to include the message about the missing font in
neateqn.pdf instead of printing it while building neateqn.pdf.
Thanks,
Ali
|
Hi Ali,
Thanks for your reply! :)
I printed the message while building the docs because a reader of
neateqn may notice, that "there is something wrong" (using the same
font twice) and could decide to send you an error report or something
you need to react on (think about my hassle to understand the whole
thing :).
This way he is informed, that this """""failure""""" is intentionally
and s/he needs to read the doc to get the output as originally
intended.
Fixing quotes: How should I handle this? Can I create another pull
request?
What do you think ? -- You are the HEAD :) of your github repo ... :)
:) :)
Best wishes,
Meino
…On 02/28 08:06, Ali Gholami Rudi wrote:
mcctuxic ***@***.***> wrote:
> Added some informations for first time users of neatroff how to install and use some extra fonts for the documentation
Very good.
A few suggestions:
+ Copying the contents of afm and pfb folders are necessary and adequate.
+ It is better to use \(lq and \(rq instead of double quotes.
+ I think it is better to include the message about the missing font in
neateqn.pdf instead of printing it while building neateqn.pdf.
Thanks,
Ali
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#10 (comment)
|
Hi Meino,
mcctuxic <notifications@github.com> wrote:
Thanks for your reply! :)
I printed the message while building the docs because a reader of
neateqn may notice, that "there is something wrong" (using the same
font twice) and could decide to send you an error report or something
you need to react on (think about my hassle to understand the whole
thing :).
This way he is informed, that this """""failure""""" is intentionally
and s/he needs to read the doc to get the output as originally
intended.
If the message is included in neateqn.pdf itself, I think it is easier
to explain that installing these fonts is necessary, only if you want to
use them.
Fixing quotes: How should I handle this? Can I create another pull
request?
What do you think ? -- You are the HEAD :) of your github repo ... :)
:) :)
And I have already merged the second patch!
Separate feature branches are easier to manage (and rebase).
For me, as long as I can extract the patch, it is OK with me.
Thanks,
Ali
|
Hi Ali,
I have sent you a new pull-request, which includes the
improvements you have suggeested.
And...I am feeling guilty...I think....somehow...
I created a new branch locally, made the changes, added
neateqn.mss and commit it. Then I pushed it onto the server
and created the pull request...as "always".
This time github informed me about a conflict I have
created on your repo :-/
What did I wrong here? Sorry ....I am confused...
Cheers!
Meino
…On 02/28 03:46, Ali Gholami Rudi wrote:
Hi Meino,
mcctuxic ***@***.***> wrote:
> Thanks for your reply! :)
>
> I printed the message while building the docs because a reader of
> neateqn may notice, that "there is something wrong" (using the same
> font twice) and could decide to send you an error report or something
> you need to react on (think about my hassle to understand the whole
> thing :).
> This way he is informed, that this """""failure""""" is intentionally
> and s/he needs to read the doc to get the output as originally
> intended.
If the message is included in neateqn.pdf itself, I think it is easier
to explain that installing these fonts is necessary, only if you want to
use them.
> Fixing quotes: How should I handle this? Can I create another pull
> request?
>
> What do you think ? -- You are the HEAD :) of your github repo ... :)
> :) :)
And I have already merged the second patch!
Separate feature branches are easier to manage (and rebase).
For me, as long as I can extract the patch, it is OK with me.
Thanks,
Ali
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#10 (comment)
|
Hi Meino,
mcctuxic <notifications@github.com> wrote:
I created a new branch locally, made the changes, added
neateqn.mss and commit it. Then I pushed it onto the server
and created the pull request...as "always".
This time github informed me about a conflict I have
created on your repo :-/
What did I wrong here? Sorry ....I am confused...
No problem (actually the conflict is on your own repository).
By the way, you can "rebase" your feature branch to apply the
changes on the most recent version of the master branch.
Thanks,
Ali
|
Hi Ali,
when it comes to github I am quite a newbie and with each
pull-request I create, I fear to screw things up in your neat*
repos....
"rebase" means to apply all changes in "master" to my current
local branch -- is that right?
Normally I creat a bew branch for each change/group of changes,
which fit into one "thing" or "topic", which I want to fix/address.
If you have apllied the according pull-request...is it save
for me on my side (?site? :) :) :) ), to delete the according branch?
Otherwise the count of branches will become more and more.
Or what is better to do else?
Best wishes,
Meino
…On 03/01 12:56, Ali Gholami Rudi wrote:
Hi Meino,
mcctuxic ***@***.***> wrote:
> I created a new branch locally, made the changes, added
> neateqn.mss and commit it. Then I pushed it onto the server
> and created the pull request...as "always".
>
> This time github informed me about a conflict I have
> created on your repo :-/
>
> What did I wrong here? Sorry ....I am confused...
No problem (actually the conflict is on your own repository).
By the way, you can "rebase" your feature branch to apply the
changes on the most recent version of the master branch.
Thanks,
Ali
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#10 (comment)
|
Hi Meino,
mcctuxic <notifications@github.com> wrote:
when it comes to github I am quite a newbie and with each
pull-request I create, I fear to screw things up in your neat*
repos....
"rebase" means to apply all changes in "master" to my current
local branch -- is that right?
Normally I creat a bew branch for each change/group of changes,
which fit into one "thing" or "topic", which I want to fix/address.
That is good. Such branches are usually called topic or feature
branches. To keep such branches up to date (for easier merging)
you can rebase them on a recent version of master.
If you have apllied the according pull-request...is it save
for me on my side (?site? :) :) :) ), to delete the according branch?
Yes, it is.
Best wishes,
Ali
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some informations for first time users of neatroff how to install and use some extra fonts for the documentation