Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to make constraints optional #400

Merged
merged 1 commit into from Dec 15, 2016
Merged

Added ability to make constraints optional #400

merged 1 commit into from Dec 15, 2016

Conversation

dusktreader
Copy link
Contributor

Adresses issue #399

If a constraint is optional (has a key,value of optional=True), then
it will only be applied to the table when the table has a field
present to which the constraint applies. Thus, if a constraint is
added for the field 'foo' and that constraint is designated as
optional, then any table checked by the constraint will only have the
constraint applied if the table has a field named 'foo'

  If a constraint is optional (has a key,value of optional=True), then
  it will only be applied to the table when the table has a field
  present to which the constraint applies. Thus, if a constraint is
  added for the field 'foo' and that constraint is designated as
  optional, then any table checked by the constraint will only have the
  constraint applied if the table has a field named 'foo'
@alimanfoo
Copy link
Collaborator

alimanfoo commented Dec 1, 2016 via email

@dusktreader
Copy link
Contributor Author

@alimanfoo have you had a chance to review this yet?

@alimanfoo
Copy link
Collaborator

alimanfoo commented Dec 13, 2016 via email

@alimanfoo alimanfoo merged commit 3928e19 into petl-developers:master Dec 15, 2016
@alimanfoo
Copy link
Collaborator

Looks great to me, thank you!

@alimanfoo alimanfoo added this to the v1.2 milestone Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants