Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py should check for pysam==0.8.0 #39

Closed
iosonofabio opened this issue Dec 8, 2014 · 2 comments
Closed

setup.py should check for pysam==0.8.0 #39

iosonofabio opened this issue Dec 8, 2014 · 2 comments

Comments

@iosonofabio
Copy link

Hi,

I see you put various install checks in setup.py, I think there should be one for pysam 0.8.0. 0.7 won't work, and 0.8.1 neither (yet).

Otherwise the user gets mysterious Cython errors and it takes a while to figure it's just the wrong pysam version.

Thx
F

@alimanfoo
Copy link
Owner

Thanks, will do.

@alimanfoo
Copy link
Owner

pysamstats v0.21 supports pysam 0.8.1.

I've added an install_requires keyword argument to setup(), however this doesn't prevent compile errors from occurring if pysam 0.8.0 or earlier is present on the system, as the compilation step occurs before pip checks for install requirements.

I tried using the setup_requires keyword argument, however I believe this results in pysam getting downloaded and installed twice without much feedback to the user, which leads to a long and rather opaque install process. So I've removed the setup_requires argument, I think the best option in general is to manually install dependencies before installing pysamstats.

On the GitHub README I've tried to add some careful documentation about how to install, hopefully this will avoid too much install pain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants