Separate workflow to test unsupported package manager platform #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosteo
force-pushed
the
feat/unsupported
branch
from
7b32f21
to
39aef44
Compare
mosteo
force-pushed
the
feat/unsupported
branch
from
a1529b5
to
ad7a463
Compare
Before the last changes to break circularities, we tried to load the manifest as part of the config loading process. Now we are satisfied with finding a properly named file at the expected place. This causes one test to not detect invalid TOML, since the manifest contents aren't really needed for the test.
Fabien-Chouteau
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the end I went for a Linux instead of the suggested Windows in #601 because Windows is at present giving us more problems, with sporadic failures with unidentified causes. Also the test is quicker not requiring the CE setup.
Depends on #621
This PR adds a new config option,
distribution.disable-detection, that results in an unknown distribution always being reported.To break circularity problems, loading the configuration no longer requires to load the manifest, only to locate it. This caused one test to err slightly later (as it does not need the manifest contents), which accounts for the test modification.