Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update electric.json #75

Merged
merged 1 commit into from
Apr 25, 2022
Merged

update electric.json #75

merged 1 commit into from
Apr 25, 2022

Conversation

ClaudiaLie
Copy link
Collaborator

#Updated electric.json

Pull Request References:

#18

PR Includes:

ADDITIONS

  • 8 more cars added

UPDATES

  • fields updated to display better specifications

DELETED/REMOVED ITEMS/FEATURES

  • deleted old electric.json

Breaking changes

  • None

Screenshots/Gifs/Media

@ClaudiaLie ClaudiaLie requested a review from nlenno1 April 24, 2022 22:27
alissatroiano
alissatroiano requested changes Apr 24, 2022
View reviewed changes
Copy link
Owner

@alissatroiano alissatroiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! There are still no results when the user selects 'compact' for car type and 'over $50,000" for the budget. Everything else looks great!

@alissatroiano alissatroiano merged commit b36fe06 into main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alissatroiano alissatroiano alissatroiano approved these changes

@nlenno1 nlenno1 Awaiting requested review from nlenno1

@Darlyn-Lurikah Darlyn-Lurikah Awaiting requested review from Darlyn-Lurikah

Assignees

@nlenno1 nlenno1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ClaudiaLie @alissatroiano @nlenno1