feat(confirmation): add cli to yield confirmation #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. [Link]
What was done?
A new feature was added to yield confirmation in the CLI. This was done by modifying the
create_pr,get_branch_info,_get_valid_commits,_get_highlight_commits, and_get_diff_changesfunctions ingh.py,gitutil.py, andmain.pyfiles. The changes allow the user to confirm the creation of a GitHub PR, select commits to be ignored, select main commits, and ignore certain files.How was it done?
The changes were made by adding a new parameter
yield_confirmationto the functions. This parameter is used to control whether the user is asked for confirmation or not. Ifyield_confirmationisTrue, the user is not asked for confirmation and the default options are used.How was it tested?
The changes were tested by running the modified functions and checking if the new feature works as expected. The tests included creating a PR, ignoring commits, selecting main commits, and ignoring files.