Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use short_hash instead of commit_hash in version numbers #1201

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Use short_hash instead of commit_hash in version numbers #1201

merged 1 commit into from
Jun 15, 2018

Conversation

teo
Copy link
Contributor

@teo teo commented Jun 15, 2018

No description provided.

@teo teo requested review from a team as code owners June 15, 2018 10:07
@dberzano
Copy link
Contributor

All those three packages should belong to @alisw/dataflow-experts. Can you amend the CODEOWNERS in the same PR?

@dberzano
Copy link
Contributor

Also, I'd retain the - as separator instead of . (matter of taste/consistency mostly eh, dots have special meanings in RPMs and they will be replaced by the published in any case).

dberzano
dberzano approved these changes Jun 15, 2018
View reviewed changes
Copy link
Contributor

@dberzano dberzano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@teo teo merged commit e9fb1be into alisw:master Jun 15, 2018
@teo teo deleted the control-versions branch June 15, 2018 11:53
Barthelemy pushed a commit to Barthelemy/alidist that referenced this pull request Jul 3, 2018
@teo @Barthelemy
Use short_hash instead of commit_hash in version numbers (alisw#1201)
5233515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dberzano dberzano dberzano approved these changes

@vascobarroso vascobarroso vascobarroso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teo @dberzano @vascobarroso