Changing AEGIS recipe for Sonoma build #5191
Conversation
|
Tagging @TimoWilken |
|
Thank you very much @ChSonnabend! I'll mark the PR as "ready for review" so that the CI will run. |
| @@ -21,7 +21,8 @@ if [ $FVERSION -ge 10 ]; then | |||
| echo "Fortran version $FVERSION" | |||
| SPECIALFFLAGS=1 | |||
| fi | |||
| cmake $SOURCEDIR -DCMAKE_INSTALL_PREFIX=$INSTALLROOT \ | |||
| cmake $SOURCEDIR -DCMAKE_CXX_FLAGS=-isystem\ "/opt/homebrew/include" \ | |||
There was a problem hiding this comment.
What are you trying to achieve here?
There was a problem hiding this comment.
This was needed to find the system dependencies for nlohmann/json. Not sure if this is needed in general, but I added it here for now.
There was a problem hiding this comment.
If this is some "out-of-band" external, we should probably have a separate recipe for it.
boost.sh
Outdated
| version: v1.75.0 | ||
| tag: v1.75.0 | ||
| version: v1.82.0 | ||
| tag: v1.82.0 |
There was a problem hiding this comment.
We have a separate PR for this (#5140), however it breaks running multiple O2 tests in parallel. Until that is understood and solved, we cannot merge it.
There was a problem hiding this comment.
Ah ok, this I didn't know. For me it works on Sonoma (and it works only like this, not with the older version...).
There was a problem hiding this comment.
Yes, it compiles and runs fine with 1.82.0 as long as you run one workflow at the time. When you run more than one, sometimes it fails. You can find more details in the error report of the other PR.
There was a problem hiding this comment.
Thank you for your contribution. I have a few comments inline. I would use the orginal PR for the boost changes. Moreover, the aegis changes cannot be merged as they are, since they hardcode a global system path in the search. If you really do not want to package json for now, you should at least use $(brew --prefix json)/include and have it as part of a macOS specific flag.
ChSonnabend
force-pushed
the
sonoma_build
branch
from
a34d37f
to
e62569b
Compare
ChSonnabend
changed the title
|
After some exchanges with @ktf only the AEGIS changes were integrated in this PR. |
Modifying dependencies of
for a successful build on macOS Sonoma