Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for sdk/requests/common_request.go #112

Merged
merged 2 commits into from
Nov 11, 2018
Merged

Conversation

JacksonTian
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 11, 2018

Codecov Report

Merging #112 into master will increase coverage by 2.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage    52.7%   55.43%   +2.73%     
==========================================
  Files          22       22              
  Lines        1146     1140       -6     
==========================================
+ Hits          604      632      +28     
+ Misses        488      453      -35     
- Partials       54       55       +1
Impacted Files Coverage Δ
sdk/requests/common_request.go 63.82% <ø> (+52.5%) ⬆️
sdk/client.go 28.13% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bca73c...c4d6009. Read the comment docs.

@JacksonTian JacksonTian merged commit e8fe0a2 into master Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants