Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 2.2.3 bugs #23

Merged
merged 2 commits into from
Jul 19, 2016
Merged

fix 2.2.3 bugs #23

merged 2 commits into from
Jul 19, 2016

Conversation

baiyubin
Copy link
Contributor

修复3个bug：

  1. 分片上传提交时不在要求PartETags是顺序的，completeMultipartUpload自动排序，然后提交；
  2. OSSClient.shutdown会抛出InterruptedException，抛该异常是正常的，添加try catch防止抛给用户；
  3. 使用setProxyHost是会core，参加setProxy无法使用 #19

rockuw
rockuw reviewed Jul 19, 2016
View reviewed changes
src/main/java/com/aliyun/oss/OSSClient.java
serviceClient.shutdown();
try {
serviceClient.shutdown();
} catch(Exception e) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里最好加一条log吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已添加。

@baiyubin baiyubin merged commit a7ec681 into master Jul 19, 2016
@baiyubin baiyubin deleted the fix_2.2.3_bugs branch October 27, 2017 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@baiyubin @rockuw @baiyubin2020