support wj poc #60
Merged
support wj poc #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $options[self::OSS_BUCKET] = $bucket; | ||
| $options[self::OSS_METHOD] = self::OSS_HTTP_GET; | ||
| $options[self::OSS_OBJECT] = '/'; | ||
| $options[self::OSS_SUB_RESOURCE] = 'location'; |
There was a problem hiding this comment.
location, qos定义成一个宏比较好, 不过现存代码都是这样的,这个后面我来改吧
| $this->assertTrue(false); | ||
| } catch (OssException $e) { | ||
| $this->assertEquals('InvalidArgument', $e->getErrorCode()); | ||
| } |
There was a problem hiding this comment.
BucketStorageCapacity对用户有最大限制吗？ 如果有应该增加一个case。
| $this->ossClient->putBucketStorageCapacity($this->bucket, - 2); | ||
| $this->assertTrue(false); | ||
| } catch (OssException $e) { | ||
| $this->assertEquals('InvalidArgument', $e->getErrorCode()); |
There was a problem hiding this comment.
这里还要验证http status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
变更内容