Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support jpa enhancement of java 8 classes #351

Merged
merged 1 commit into from Jan 7, 2016
Merged

Support jpa enhancement of java 8 classes #351

merged 1 commit into from Jan 7, 2016

Conversation

gallardo
Copy link
Contributor

OpenJPA 2.2 doesn't support enhancement for Java 8 classes (see https://issues.apache.org/jira/browse/OPENJPA-2386)

OpenJPA 2.2 doesn't support enhancement for Java 8 classes (see https://issues.apache.org/jira/browse/OPENJPA-2386)
@gallardo
Copy link
Contributor Author

OpenJPA 2.2 doesn't support enhancement for Java 8 classes (see https://issues.apache.org/jira/browse/OPENJPA-2386):

Execution failed for task ':enhance'.
> java.lang.IllegalArgumentException

This issue is solved in OpenJPA 2.4.

Unfortunately, gradle cannot pull maven transitive dependencies, so we have to explicitly add org.apache.xbean:xbean-asm5-shaded. (Alternatively, org.apache.openjpa:openjpa-all:2.4.0 has all needed dependencies, but I opted for the lightest dependencies declaration).

We'll still see warnings though, due to https://issues.apache.org/jira/browse/OPENJPA-2300.

Detailed stacktrace snippet for the record:

ant:openjpaenhancer] java.lang.IllegalArgumentException
[ant:openjpaenhancer]   at org.objectweb.asm.ClassReader.<init>(Unknown Source)
[ant:openjpaenhancer]   at org.objectweb.asm.ClassReader.<init>(Unknown Source)
[ant:openjpaenhancer]   at org.objectweb.asm.ClassReader.<init>(Unknown Source)
[ant:openjpaenhancer]   at org.apache.openjpa.enhance.AsmAdaptor.toJava7ByteArray(AsmAdaptor.java:93)
[ant:openjpaenhancer]   at org.apache.openjpa.enhance.AsmAdaptor.writeJava7(AsmAdaptor.java:84)
[ant:openjpaenhancer]   at org.apache.openjpa.enhance.AsmAdaptor.write(AsmAdaptor.java:54)
[ant:openjpaenhancer]   at org.apache.openjpa.enhance.PCEnhancer.record(PCEnhancer.java:633)
...

@tHerrmann tHerrmann merged commit db0db41 into alkacon:branch_9_5_x Jan 7, 2016
@gallardo gallardo deleted the patch-8 branch January 14, 2016 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants