Code review #794
Merged
Code review #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files previously located in `webapp/setup/database/**` were moved to `webapp/WEB-INF/setupdata/database/**` in OpenCms 11.0. Given that we have currently OpenCms 16.0, we can safely conclude that this dependency is no longer necessary.
This step passes always.
Gradle's `java` plugin already adds `jar` to the `archives` configuration. See result of `./gradlew outgoingVariants --variant archives | grep opencms.jar`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request consolidates small changes and improvements in the code from debugging sessions. I have kept the changes as atomic as possible for easy understanding.