-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG+2] Fix conda deployments #300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is :big-brain-time:
. How do we test?
@tgsmith61591 We can use the |
Hey @aaronreidsmith Was this fix ever pushed to the production channel? |
Not quite yet, sorry for the delay! We have a couple more features/fixes before we deploy. Conda builds were new for all of the maintainers, and added in 1.5.3, so apologies for the hiccups. Use |
Thanks :) |
@TariqAHassan I hate to be the bearer of bad news on this, but v1.6.0 will actually not have conda support. See issue #326 for details, but basically we have tried and failed several times to get this package to build properly on conda for the platforms we support on pypi. If you or anyone you know who uses the package happens to be a conda expert, help/PRs are welcome! |
Description
We ran into a bunch of issues when deploying 1.5.3. The only one that is still affecting us is that our conda builds are broken. A normal conda build should have both an
info
directory and alib
directory (Lib
on Windows). Here is a version ofpmdarima
on conda that we did not create:Here is one we created:
As you can see, ours only has the
info
directory.Here is what is included/addressed in this PR:
Conda is silly in that when it builds, it installs to the default
site-packages
for testing, but then does not include that in the output...site-packages
and$PREFIX/site-packages
($PREFIX
is a conda env variable). One gets tested running our unit tests, the other is bundled in the outputtar.bz2
Related to the above change, before deploying, we now check to make sure the output
tar.bz2
has alib
(orLib
on Windows) directory before deploying (it is a requirement for deployment now)Previous iterations of this conda pipeline had 3 separate files for our operating systems. We still have 3 files, but now we have
common
, for steps shared between all operating systems,unix
for steps shared between Linux and macOS, andwindows
for Windows. This should save us time/energy when we have to update this pipeline.We no longer build a wheel before building the conda distribution on Unix
Fix silent error where
$output_file
was not defined after moving to using a separate deploy scriptFixes our conda string to look something like this:
py37gcd6b1ea6_68
instead ofpy37
Fixes #298
Type of change
How Has This Been Tested?
lib
directoriesChecklist: