-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG+2] Remove conda support #325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. We always have the Azure stuff stashed in past tags if we ever need to go back to it, but for now at least our build process is much more simple.
@@ -129,6 +129,3 @@ ENV/ | |||
|
|||
# We want this to only be created on CI/CD platforms | |||
VERSION | |||
|
|||
# Since we use a Jinja Template, we only want this to be created as build time | |||
meta.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can prob keep this here incase we ever go back to trying to automate this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was removed since this branch started as actually trying to commit meta.yaml
. You're saying I should leave it in in case we go back to templating (à la #300) again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way 🤷
@@ -2,8 +2,7 @@ | |||
|
|||
[![PyPI version](https://badge.fury.io/py/pmdarima.svg)](https://badge.fury.io/py/pmdarima) | |||
[![CircleCI](https://circleci.com/gh/alkaline-ml/pmdarima.svg?style=svg)](https://circleci.com/gh/alkaline-ml/pmdarima) | |||
[![Build Status](https://dev.azure.com/tgsmith61591gh/pmdarima/_apis/build/status/alkaline-ml.pmdarima?branchName=master)](https://dev.azure.com/tgsmith61591gh/pmdarima/_build/latest?definitionId=3&branchName=master) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RIP
Description
For the life of me, I cannot figure out conda. I have ended up in the following situations:
This PR removes all conda support (which, by definition, moves us off of Azure Pipelines entirely). The only thing it adds is a link from the GH badge to the GH Actions page, lol.
I will open an issue for first-party conda support and add a
help-wanted
tag, because it is impacting the release of features at this point.Type of change
How Has This Been Tested?
pypi builds still work 🤷♂️
Checklist: