Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+2] Remove conda support #325

Merged
merged 26 commits into from
Apr 27, 2020
Merged

[MRG+2] Remove conda support #325

merged 26 commits into from
Apr 27, 2020

Conversation

aaronreidsmith
Copy link
Member

Description

For the life of me, I cannot figure out conda. I have ended up in the following situations:

  • Will build for 3.7 on all platforms (but not 3.6)
  • Will build for 3.6 on all platforms (but not 3.7)
  • Will build for only Linux, and nothing else

This PR removes all conda support (which, by definition, moves us off of Azure Pipelines entirely). The only thing it adds is a link from the GH badge to the GH Actions page, lol.

I will open an issue for first-party conda support and add a help-wanted tag, because it is impacting the release of features at this point.

Type of change

  • Documentation change
  • CI/CD Change

How Has This Been Tested?

pypi builds still work 🤷‍♂️

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@aaronreidsmith aaronreidsmith added the cicd Issues related to CI/CD platforms label Apr 24, 2020
@aaronreidsmith aaronreidsmith changed the title Remove conda support [MRG] Remove conda support Apr 25, 2020
Copy link
Member

@tgsmith61591 tgsmith61591 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We always have the Azure stuff stashed in past tags if we ever need to go back to it, but for now at least our build process is much more simple.

@@ -129,6 +129,3 @@ ENV/

# We want this to only be created on CI/CD platforms
VERSION

# Since we use a Jinja Template, we only want this to be created as build time
meta.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can prob keep this here incase we ever go back to trying to automate this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed since this branch started as actually trying to commit meta.yaml. You're saying I should leave it in in case we go back to templating (à la #300) again?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way 🤷

@@ -2,8 +2,7 @@

[![PyPI version](https://badge.fury.io/py/pmdarima.svg)](https://badge.fury.io/py/pmdarima)
[![CircleCI](https://circleci.com/gh/alkaline-ml/pmdarima.svg?style=svg)](https://circleci.com/gh/alkaline-ml/pmdarima)
[![Build Status](https://dev.azure.com/tgsmith61591gh/pmdarima/_apis/build/status/alkaline-ml.pmdarima?branchName=master)](https://dev.azure.com/tgsmith61591gh/pmdarima/_build/latest?definitionId=3&branchName=master)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP

@aaronreidsmith aaronreidsmith changed the title [MRG] Remove conda support [MRG+1] Remove conda support Apr 27, 2020
@aaronreidsmith aaronreidsmith changed the title [MRG+1] Remove conda support [MRG+2] Remove conda support Apr 27, 2020
@aaronreidsmith aaronreidsmith merged commit d05a64f into master Apr 27, 2020
@aaronreidsmith aaronreidsmith deleted the conda-from-pypi branch April 27, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd Issues related to CI/CD platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants