Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual contributor Profile #6170

Merged
merged 43 commits into from
Jun 3, 2024
Merged

Virtual contributor Profile #6170

merged 43 commits into from
Jun 3, 2024

Conversation

bobbykolev
Copy link
Contributor

@bobbykolev bobbykolev commented May 10, 2024 •
edited

#5862

VC Profile including:

Dynamic part:

  • Name;
  • Avatar;
  • VC label;
  • tagline; (added to VC creation)
  • tags; (added to VC creation)
  • Description;
  • Host ORG
  • references;

Go out as hardcoded (in translations):

  • knowledge block;
    • BoK space is dynamic;
  • personality block;
  • context block;
  • privacy section;

Screenshot 2024-05-30 132522

@bobbykolev bobbykolev marked this pull request as ready for review May 28, 2024 13:24
bobbykolev and others added 16 commits May 28, 2024 17:20
@bobbykolev
VC rework the HostOrganization to Host supporting hostProfile prop
2ce0615
@bobbykolev
Merge branch 'develop' into client-5862
1cc2cce
@bobbykolev
VC Profile - VC Default space display + style improvements
2599604
@bobbykolev
VC Profile - host section title from translations
5e72923
@bobbykolev
Merge branch 'develop' into client-5862
32c70ea
@bobbykolev
merge develop into client-5862
c4c6a80
@bobbykolev
VC Profile - fix codegen; profile settings route and layout
176fcf9
@valentinyanakiev
Removed prompt from the New Virtual Persona Form
13533ef
@bobbykolev
VC Profile remove redundant file
6323622
@bobbykolev
VC Edit Profile init
891d0d9
@bobbykolev
VC Edti - working form with basic info updates
f5c845e
@valentinyanakiev
Revert "Removed prompt from the New Virtual Persona Form"
8353005 
This reverts commit 13533ef.
@valentinyanakiev
Merge remote-tracking branch 'origin/client-5862' into client-5862
eb9f84f
@valentinyanakiev
Revert prompt
97a07ac
@bobbykolev
vc host related inputs
59356b2
@bobbykolev
vc profile - dynamic display of Host and BodyOfKnowledge subpace
6177e16
@bobbykolev bobbykolev requested a review from ccanos May 30, 2024 10:35
ccanos
ccanos previously requested changes May 30, 2024
View reviewed changes
Copy link
Contributor

@ccanos ccanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please take a look at the comments

src/domain/community/virtualContributor/VirtualContributor.graphql Show resolved Hide resolved
src/main/routing/urlBuilders.ts Outdated Show resolved Hide resolved
src/main/routing/urlBuilders.ts Outdated Show resolved Hide resolved
src/domain/community/virtualContributor/layout/VCPageLayout.tsx Outdated Show resolved Hide resolved
src/domain/community/virtualContributor/layout/VCPageBanner.tsx Outdated Show resolved Hide resolved
src/domain/community/virtualContributor/vcProfilePage/SpaceHorizontalCard.tsx Outdated Show resolved Hide resolved
src/domain/community/virtualContributor/vcProfilePage/SpaceHorizontalCard.tsx Outdated Show resolved Hide resolved
src/domain/community/virtualContributor/vcProfilePage/HostCardClean.tsx Outdated Show resolved Hide resolved
src/domain/community/virtualContributor/vcProfilePage/VCProfilePage.tsx Outdated Show resolved Hide resolved
src/domain/community/virtualContributor/vcSettingsPage/VCSettingsPage.tsx Outdated Show resolved Hide resolved
@bobbykolev bobbykolev requested a review from ccanos May 30, 2024 15:38
@bobbykolev
Copy link
Contributor Author

please take a look at the comments

Fixes applied, thanks for reviewing it, @ccanos

me-andre
me-andre requested changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@me-andre me-andre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobbykolev , please have a look at the comments

@bobbykolev bobbykolev requested a review from me-andre June 3, 2024 09:38
@me-andre me-andre dismissed ccanos’s stale review June 3, 2024 09:43

Requests addressed

@bobbykolev bobbykolev merged commit 8bb4785 into develop Jun 3, 2024
2 checks passed
@valentinyanakiev valentinyanakiev deleted the client-5862 branch June 6, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-andre me-andre me-andre approved these changes

@valentinyanakiev valentinyanakiev valentinyanakiev approved these changes

@ccanos ccanos Awaiting requested review from ccanos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bobbykolev @me-andre @valentinyanakiev @ccanos