fix: using a custom badge template breaks badge replacement #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kharaone
added a commit
to kharaone/all-contributors
that referenced
this pull request
Oct 17, 2019
Update of the documentation for all-contributors/cli#210, we update
2 tasks
Berkmann18
approved these changes
Oct 18, 2019
Berkmann18
changed the title
|
@all-contributors Please add @kharaone for code |
|
I've put up a pull request to add @kharaone! 🎉 |
Berkmann18
pushed a commit
to all-contributors/all-contributors
that referenced
this pull request
Oct 19, 2019
Update of the documentation for all-contributors/cli#210, we update
|
🎉 This PR is included in version 6.9.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
I think this was a breaking change. All Contributors badge will no longer be updated unless they wrap their badge in the following tags |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fixes #120
Why:
Some repositories want to use HTML templates or custom templates for the badges
How:
changed the check done through an hardcoded regex to a simple "is it between these 2 tags"
Checklist:
Credits to @simbas
docs are done through all-contributors/all-contributors#312