Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure a11y contributions work for the bot #263

Merged
merged 2 commits into from
Nov 30, 2019

Conversation

jakebolam
Copy link
Contributor

@jakebolam jakebolam commented Nov 27, 2019

Test snapshots were also updated, as we are a few versions behind on the CLI package bump:
https://github.com/all-contributors/all-contributors-cli/releases

See snap update: https://github.com/all-contributors/all-contributors-bot/pull/263/files#diff-855d698d4c6693c8d648ddf5e94b8856

Note: This change includes:
all-contributors/cli#210

Which has a breaking change where the All Contributors badge will no longer be updated unless they wrap their badge in the following tags

<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
BADGE
<!-- ALL-CONTRIBUTORS-BADGE:END --> 

@jakebolam
Copy link
Contributor Author

Should we document an upgrade guide? uggghh breaking change

@Berkmann18
Copy link
Member

@jakebolam It would be the best thing to do I think.

@jakebolam
Copy link
Contributor Author

@jakebolam jakebolam merged commit 7d800d2 into master Nov 30, 2019
@jakebolam jakebolam deleted the fix/fix-a11y-contribution branch November 30, 2019 03:23
@all-contributors-release-bot
Copy link
Member

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants