Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a11y contribution type #326

Merged
merged 1 commit into from Nov 10, 2019
Merged

feat: add a11y contribution type #326

merged 1 commit into from Nov 10, 2019

Conversation

phacks
Copy link
Contributor

@phacks phacks commented Nov 8, 2019

What: Add a11y (Accessibility) contribution type.

Why: Discussed in #320

How: Added a new contribution type in the emoji key

Checklist:

  • Documentation
  • Ready to be merged
  • Added myself to contributors table.
    Bot Usage

@phacks phacks mentioned this pull request Nov 8, 2019
Closed
gr2m
gr2m approved these changes Nov 8, 2019
View reviewed changes
Copy link

@gr2m gr2m left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Let's leave it open for a week to give others time to comment

Berkmann18
Berkmann18 approved these changes Nov 9, 2019
View reviewed changes
Copy link
Member

@Berkmann18 Berkmann18 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too.
@sinchang and some users seemed to approve the idea so I think it's good to go!
LGTM!

Also, don't forget to update the https://github.com/all-contributors/all-contributors-bot repo as well.

@Berkmann18 Berkmann18 added documentation Documentation related issue/PR enhancement New feature or request status: review needed labels Nov 9, 2019
@Berkmann18 Berkmann18 added this to In progress in All Contributors Kanban via automation Nov 9, 2019
@gr2m gr2m merged commit 9f1cb4f into all-contributors:master Nov 10, 2019
All Contributors Kanban automation moved this from In progress to Done Nov 10, 2019
@all-contributors-release-bot
Copy link
Member

🎉 This PR is included in version 2.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gr2m
Copy link

gr2m commented Nov 10, 2019

@all-contributors please add @phacks for doc

@allcontributors allcontributors bot mentioned this pull request Nov 10, 2019
Merged
@allcontributors
Copy link
Contributor

@gr2m

I've put up a pull request to add @phacks! 🎉

@gr2m gr2m mentioned this pull request Nov 10, 2019
Merged
4 tasks
@phacks
Copy link
Contributor Author

phacks commented Nov 11, 2019

Also, don't forget to update the https://github.com/all-contributors/all-contributors-bot repo as well.

@Berkmann18 what should I update in that repo?

@phacks phacks deleted the feat-add-a11y-contribution-type branch November 11, 2019 17:44
@Berkmann18
Copy link
Member

@phacks This file.

@phacks
Copy link
Contributor Author

phacks commented Nov 11, 2019

@Berkmann18 Awesome, thanks! I created the related PR: all-contributors/app#259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

@Berkmann18 Berkmann18 Berkmann18 approved these changes

Assignees
No one assigned
Labels
documentation Documentation related issue/PR enhancement New feature or request released status: accepted
Projects
No open projects
All Contributors Kanban
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@phacks @all-contributors-release-bot @gr2m @Berkmann18