New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a11y contribution type #223
feat: add a11y contribution type #223
Conversation
src/util/contribution-types.js
Outdated
a11y: { | ||
symbol: '️️️️♿️', | ||
description: 'Accessibility', | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot a comma :)
} | |
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the permission to fix it myself. @phacks can you or someone with write access get this fix commited so we can merge the PR? I've already merged the PR for the website: all-contributors/all-contributors#326
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried fixing this but I don't have permission either, that being said I didn't try to fix that locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops 🙈 I corrected this in 485e598, sorry about that!
Don't worry about that part, we can always do that as this PR gets merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank you.
@Berkmann18 Hi! I think this PR can be merged, now that I fixed the typo and created all-contributors/app#259, what do you think? |
@all-contributors Please add @phacks for code |
I've put up a pull request to add @phacks! 🎉 |
🎉 This PR is included in version 6.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What: Add
a11y
(Accessibility) contribution type.Why: Discussed in all-contributors/all-contributors#320
How: Added a new contribution type in
src/util/contribution-types.js
Checklist:
I’ve yet to figure out how to add myself to the contributors table, can I use the @all-contributors bot to this end?