Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Accessibility (a11y) emoji key #320

Closed
phacks opened this issue Oct 30, 2019 · 16 comments
Closed

New Accessibility (a11y) emoji key #320

phacks opened this issue Oct 30, 2019 · 16 comments
Assignees
Labels
discussion Discussion relevant to the repo enhancement New feature or request

Comments

@phacks
Copy link
Contributor

phacks commented Oct 30, 2019

Is your feature request related to a problem? Please describe.

On https://github.com/theodo/falco, we are seeing a few contributors reporting a11y issues and/or pushing a11y-related pull requests. I feel like those contributions should be properly rewarded by a specific emoji key.

Describe the solution you'd like

A new emoji key, called a11y or accessibility:

Emoji/Type Represents Comments
♿️
a11y
Accessibility Reporting or working on accessibility issues

Describe alternatives you've considered

I’m not convinced by my choice of emoji, here are a few other suggestions: 🕊🙌✨

@phacks phacks added the enhancement New feature or request label Oct 30, 2019
@Berkmann18
Copy link
Member

That's a great idea.
The ♿ seems to be the best for this as far as I can tell.

@all-contributors/core Any thoughts/objections?

@allcontributors
Copy link
Contributor

@Berkmann18

I could not determine your intention.

Basic usage: @all-contributors please add @jakebolam for code, doc and infra

For other usages see the documentation

@Berkmann18 Berkmann18 self-assigned this Oct 31, 2019
@Berkmann18 Berkmann18 added the discussion Discussion relevant to the repo label Oct 31, 2019
@gr2m
Copy link

gr2m commented Nov 1, 2019

I love the idea.

@phacks
Copy link
Contributor Author

phacks commented Nov 6, 2019

Cool! Thanks for the feedbacks. Should I go forward and open a PR?

@gr2m
Copy link

gr2m commented Nov 6, 2019

Yes, thank you

@phacks
Copy link
Contributor Author

phacks commented Nov 8, 2019

PRs are ready!

Please let me know if I forgot something :)

phacks added a commit to phacks/all-contributors-bot that referenced this issue Nov 11, 2019
gr2m pushed a commit to all-contributors/app that referenced this issue Nov 17, 2019
@adswa
Copy link

adswa commented Nov 27, 2019

Hey everyone, thanks for adding this wonderful contribution type! I'm really happy to see this!

I've been trying to use this, but for some reason, I fail (this conversation):
image

What am I doing wrong? Thanks a lot in advance!

@sinchang
Copy link
Contributor

@adswa I guess that feature still not released.

@adswa
Copy link

adswa commented Nov 27, 2019

Gotcha - thanks @sinchang!

@Berkmann18
Copy link
Member

It was merged in the bot repo (cf. all-contributors/app#259) so normally it should be available.

@jakebolam
Copy link
Collaborator

Screen Shot 2019-11-27 at 1 03 12 PM

Ahh sorry, the pipeline was stopped on verify.

It's on the sandbox https://github.com/all-contributors-sandbox

@jakebolam
Copy link
Collaborator

jakebolam commented Nov 27, 2019

@jakebolam
Copy link
Collaborator

Fix is up: all-contributors/app#263

@jakebolam
Copy link
Collaborator

Fix has been released.

@KirstieJane
Copy link

KirstieJane commented Feb 10, 2020

I think this issue can close - it looks like everything's fixed?

Thanks for the great work all contibutors team!

@Berkmann18
Copy link
Member

@KirstieJane Yup, thanks for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion relevant to the repo enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants