New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Accessibility (a11y) emoji key #320
Comments
That's a great idea. @all-contributors/core Any thoughts/objections? |
I could not determine your intention. Basic usage: @all-contributors please add @jakebolam for code, doc and infra For other usages see the documentation |
I love the idea. |
Cool! Thanks for the feedbacks. Should I go forward and open a PR? |
Yes, thank you |
PRs are ready! Please let me know if I forgot something :) |
Hey everyone, thanks for adding this wonderful contribution type! I'm really happy to see this! I've been trying to use this, but for some reason, I fail (this conversation): What am I doing wrong? Thanks a lot in advance! |
@adswa I guess that feature still not released. |
Gotcha - thanks @sinchang! |
It was merged in the bot repo (cf. all-contributors/app#259) so normally it should be available. |
Ahh sorry, the pipeline was stopped on verify. It's on the sandbox https://github.com/all-contributors-sandbox |
Ah the feature/sandbox actually has an issue: |
Fix is up: all-contributors/app#263 |
Fix has been released. |
I think this issue can close - it looks like everything's fixed? Thanks for the great work all contibutors team! |
@KirstieJane Yup, thanks for the reminder. |
Is your feature request related to a problem? Please describe.
On https://github.com/theodo/falco, we are seeing a few contributors reporting a11y issues and/or pushing a11y-related pull requests. I feel like those contributions should be properly rewarded by a specific emoji key.
Describe the solution you'd like
A new emoji key, called
a11y
oraccessibility
:a11y
Describe alternatives you've considered
I’m not convinced by my choice of emoji, here are a few other suggestions: 🕊🙌✨
The text was updated successfully, but these errors were encountered: