-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal Version #85
Comments
I'd be fine with that. Feel free to PR to the spec to add a note about a minimal version being acceptable. |
@MatheusRV Have you started working on that? |
Not yet. |
Just a ideia |
That looks good to although I believe it wouldn't be similar enough to the current AC table style/format with less info (e.g. no contribution emojis). |
I think where is follow the emoji, we could improve this. I think in a 2 colum view for larger projects |
@MatheusRV The column view, that's already configurable; where the I think it's definitely a good idea to have a place where visitors can 1-click to follow someone (which could be placed where contribution emojis are?) |
I'd prefer a version that follows up on the minimal idea suggestion in the first comment, where the table only contains images and names. I currently do this manually in my project https://github.com/scalacenter/bloop but it's a little bit frustrating that the bot doesn't work if it doesn't recognise any contribution. I'd love if the bot could just append a contributor with no specific icon. |
A minimal version would be wonderful! In the meantime, switching to a markdown table would be helpful in reducing the readme size. |
You can use the |
Do you mean I'll need to remove the icons manually from the PR created by the bot? What I want is the bot to add someone in the contributor list while not adding any icon at all. Otherwise, it defeats the purpose and it's just better to add that person manually. |
True, and we may re-introduce it alongside the HTML option (cf. all-contributors/cli#173).
At the moment, yes as both the CLI and the bot requires at least one contribution type to be specified (at least until there's a minimal version implemented). I see what you're trying to do and I'm wondering why you want to omit the contribution icons. |
I want something that automates the addition of new people to the contributor list but I don't want to acknowledge (or think about) what kind of contributions they do. The contributors in my projects work on too many different things and the table goes rapidly out-of-date, so I just want their nice avatar in my README to credit them for any work instead of some specific domain work. If someone is interested in who has which rights, they usually ask in Gitter (though it's uncommon, people just ask for reviews, they don't ask who's in charge of what). |
That makes sense, in that case (for now) using the |
I like the look of the above bootstrap example best. It has room for contribution type emojis for those who track that. Also +1 for markdown table as option instead of html. |
This will get old fast. Hopefully upstream all-contributors/all-contributors#85 doesn't take too long
We wanted to do something like: This is from Open Collective, based on the GitHub contributions graph only.
What we managed to do for now: I guess we would need to be able to get rid of the table and maybe use a microservice to return circular avatars (as we can't use Via getferdi/sponsors-only#1478 |
Quick update on the latest attempt here. Via https://github.com/getferdi/ferdi/pull/266#issuecomment-617470631. |
To get the circuluar icons, one could use this template: "contributorTemplate": "<a href=\"<%= contributor.profile %>\"><img src=\"https://images.weserv.nl/?url=<%= contributor.avatar_url %>&h=<%= options.imageSize %>&w=<%= options.imageSize %>&fit=cover&mask=circle&maxage=7d\" alt=\"<%= contributor.name %>\"/>", All we need now is a configurable way to specify the wrapper element (basically to change from 'table' to 'p') This results in this output: |
Just waiting for the merge 🙌 |
🎉 This issue has been resolved in version 2.17.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Suggesting this repository for another project that I find interesting I came across a rather interesting idea:
"
I would actually like to see the minimal version of that list, one with only the Avatar + GitHub profile (or website) link. From my perspective, if it does not really matter if it was a bug, a PR code, a translation or some documentation, in the end it's a contribution and it should be recognized as a contributor, without all those emoji and huge avatar
"
@goenning in getfider/fider#612
What do you think? Very cool in my opinion.
The text was updated successfully, but these errors were encountered: