Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(questions): use a non-gender-specific emoji #49

Merged
merged 1 commit into from
Jan 22, 2017
Merged

Conversation

kentcdodds
Copy link
Collaborator

because we don't want to insinuate that answering questions is "women's work"

BREAKING CHANGE: Change "questions" from 馃拋 to 馃挰

because we don't want to insinuate that answering questions is "women's work"

BREAKING CHANGE: Change "questions" from 馃拋 to 馃挰
@kentcdodds
Copy link
Collaborator Author

ping watchers: review needed

Copy link
Collaborator

@jfmengels jfmengels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me!
Do you mind doing a similar PR on all-contributors-cli? (Btw, I think some new symbols were added to the spec but we're never added to the cli, might as well do those at the same time)

@kentcdodds
Copy link
Collaborator Author

Yep! In an airplane about to take off, but can do when I land (if nobody beats me to it 馃槈)!

@kentcdodds kentcdodds merged commit d925b9c into master Jan 22, 2017
@kentcdodds kentcdodds deleted the PR/questions branch January 22, 2017 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants