-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Category: maintenance #111
Comments
Sure 👍 |
🔩 Thoughts on this emoji for maintenance? |
I'll start the PR soon. I have a talk to give next week. Can this ticket be listed as a Hacktoberfest item? https://hacktoberfest.digitalocean.com/ |
I don't think it has to be listed for you to get credit for the PR for hacktoberfest :) |
And that emoji is perfect |
Wouldn't 👷 or 🚧 be more appropriate for "maintenance"? |
I like the construction worker hat 👷 . @Berkmann18 - It's been on my todo list but I have 2 major presentations this month. If you can finish it in January, it's all yours. If you still haven't done it by February, I'll come back and knock it out. So feel free! |
@GantMan I'll have a look at it, this week. |
I like the construction worker but don't think we should use a gender specific emoji. See all-contributors/all-contributors#49 |
@jakebolam In this case using 🚧 or perhaps 🏗 would prevent that gender association? |
Looks good to me. Happy with either. |
Okay, I'll use the former (since it's easier to understand). |
* feat(contribution-type): added maintenance type fixes #111 * docs(categories): added maintenance category * refactor: changed the maintenance symbol * refactor: alphabetical listing fix I moved the `maintenance` blocks/lines to the correct locations
🎉 This issue has been resolved in version 5.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Love the tool. I was thinking it might be great if we could have a new category for those who simply come along and update dependencies. They actually don't add code, but they help dependencies, and they maintain the "freshness" of a repo.
I've had a few come do that.
The text was updated successfully, but these errors were encountered: