Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Category: maintenance #111

Closed
GantMan opened this issue Oct 11, 2018 · 13 comments · Fixed by #142
Closed

New Category: maintenance #111

GantMan opened this issue Oct 11, 2018 · 13 comments · Fixed by #142

Comments

@GantMan
Copy link
Contributor

GantMan commented Oct 11, 2018

Love the tool. I was thinking it might be great if we could have a new category for those who simply come along and update dependencies. They actually don't add code, but they help dependencies, and they maintain the "freshness" of a repo.

I've had a few come do that.

@kentcdodds
Copy link
Collaborator

Sure 👍

@GantMan
Copy link
Contributor Author

GantMan commented Oct 11, 2018

🔩 Thoughts on this emoji for maintenance?

@GantMan
Copy link
Contributor Author

GantMan commented Oct 11, 2018

I'll start the PR soon. I have a talk to give next week.

Can this ticket be listed as a Hacktoberfest item? https://hacktoberfest.digitalocean.com/

@kentcdodds
Copy link
Collaborator

I don't think it has to be listed for you to get credit for the PR for hacktoberfest :)

@kentcdodds
Copy link
Collaborator

And that emoji is perfect

@Berkmann18
Copy link
Member

Berkmann18 commented Jan 14, 2019

Wouldn't 👷 or 🚧 be more appropriate for "maintenance"?
@GantMan If you haven't had time to do that or to work on that, I won't mind working on that.

@GantMan
Copy link
Contributor Author

GantMan commented Jan 14, 2019

I like the construction worker hat 👷 . @Berkmann18 - It's been on my todo list but I have 2 major presentations this month. If you can finish it in January, it's all yours. If you still haven't done it by February, I'll come back and knock it out.

So feel free!

@Berkmann18
Copy link
Member

Berkmann18 commented Jan 15, 2019

@GantMan I'll have a look at it, this week.

@jakebolam
Copy link
Collaborator

I like the construction worker but don't think we should use a gender specific emoji. See all-contributors/all-contributors#49

@Berkmann18
Copy link
Member

@jakebolam In this case using 🚧 or perhaps 🏗 would prevent that gender association?

@jakebolam
Copy link
Collaborator

Looks good to me. Happy with either.

@Berkmann18
Copy link
Member

Berkmann18 commented Jan 15, 2019

Okay, I'll use the former (since it's easier to understand).
EDIT: I've updated the PR.

Berkmann18 added a commit that referenced this issue Jan 16, 2019
* feat(contribution-type): added maintenance type

fixes #111

* docs(categories): added maintenance category

* refactor: changed the maintenance symbol

* refactor: alphabetical listing fix

I moved the `maintenance` blocks/lines to the correct locations
@all-contributors-release-bot
Copy link
Member

🎉 This issue has been resolved in version 5.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants