Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(processIssueComment): added 'data' contributors #288

Merged
merged 4 commits into from
Apr 28, 2020
Merged

feat(processIssueComment): added 'data' contributors #288

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2479212
feat(processIssueComment): added 'data' contributors
Jan 3, 2020
75c2a92
Updated all-contributors-cli version in yarn.lock
Jan 3, 2020
7b3df58
Typo fix in index.js
Jan 3, 2020
b4fa37f
Merge branch 'master' into data_contributor
jakebolam Apr 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
},
"dependencies": {
"@thundra/core": "^2.2.3",
"all-contributors-cli": "^6.11.2",
"all-contributors-cli": "^6.12.0",
"aws-sdk": "^2.395.0",
"compromise": "^11.13.0",
"node-fetch": "^2.3.0",
Expand Down
7 changes: 7 additions & 0 deletions src/tasks/processIssueComment/utils/parse-comment/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const validContributionTypes = [
'business',
'code',
'content',
'data',
'design',
'doc',
'eventorganizing',
Expand Down Expand Up @@ -48,6 +49,8 @@ const contributionTypeMappings = {
bugs: 'bug',
codes: 'code',
coding: 'code',
dataset: 'data',
datasets: 'data',
designing: 'design',
desigs: 'design',
doc: 'doc',
Expand Down Expand Up @@ -85,6 +88,10 @@ const contributionTypeMappings = {

// Additional terms to match to types (plurals, aliases etc) that are multi word
const contributionTypeMultiWordMapping = {
'data collection': 'data',
'data collections': 'data',
'data set': 'data',
'data sets': 'data',
'event organizing': 'eventOrganizing',
'fund finding': 'fundingFinding',
'funding finding': 'fundingFinding',
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,9 +613,9 @@ align-text@^0.1.1, align-text@^0.1.3:
longest "^1.0.1"
repeat-string "^1.5.2"

all-contributors-cli@^6.11.2:
version "6.11.2"
resolved "https://registry.yarnpkg.com/all-contributors-cli/-/all-contributors-cli-6.11.2.tgz#46f4f2ab7f7f412cfe7185b7c627a878f103e032"
all-contributors-cli@^6.12.0:
version "6.12.0"
resolved "https://registry.yarnpkg.com/all-contributors-cli/-/all-contributors-cli-6.12.0.tgz#2fe6a3dc08721ba96124e62ebdaefb8e62023f25"
dependencies:
"@babel/runtime" "^7.2.0"
async "^3.0.1"
Expand Down