Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a11y contribution type #223

Merged
merged 3 commits into from
Nov 13, 2019
Merged

feat: add a11y contribution type #223

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94da2a5
feat: add a11y contribution type
phacks Nov 8, 2019
f9e2586
Merge branch 'master' into feat-add-a11y-contribution-type
Berkmann18 Nov 9, 2019
485e598
Fix missing comma in `contribution-types.js`
phacks Nov 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/util/contribution-types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ const repo = require('../repo')

const defaultTypes = function(repoType) {
return {
a11y: {
symbol: '️️️️♿️',
description: 'Accessibility',
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot a comma :)

Suggested change
}
},

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the permission to fix it myself. @phacks can you or someone with write access get this fix commited so we can merge the PR? I've already merged the PR for the website: all-contributors/all-contributors#326

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried fixing this but I don't have permission either, that being said I didn't try to fix that locally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops 🙈 I corrected this in 485e598, sorry about that!

blog: {
symbol: '📝',
description: 'Blogposts',
Expand Down