feat(types): add/update contrib types #24
Conversation
To "upgrade" to the latest specification.
|
Rats, I might have to actually pull this down sometime... |
* Update format-contribution-type.test.js Updated the expected question emoji. * Update format-contributor.test.js Updated the expected question emoji. * Add @itaisteinherz as a contributor
* Update README.md Added the new contribution types to accommodate #24. * Add @itaisteinherz as a contributor
| @@ -88,8 +92,9 @@ These are the keys you can specify: | |||
| Thanks goes to these wonderful people ([emoji key](https://github.com/kentcdodds/all-contributors#emoji-key)): | |||
|
|
|||
| <!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section --> | |||
| | [<img src="https://avatars.githubusercontent.com/u/3869412?v=3" width="100px;"/><br /><sub>Jeroen Engels</sub>](https://github.com/jfmengels)<br />[💻](https://github.com/jfmengels/all-contributors-cli/commits?author=jfmengels) [📖](https://github.com/jfmengels/all-contributors-cli/commits?author=jfmengels) [⚠️](https://github.com/jfmengels/all-contributors-cli/commits?author=jfmengels) | [<img src="https://avatars.githubusercontent.com/u/1500684?v=3" width="100px;"/><br /><sub>Kent C. Dodds</sub>](http://kentcdodds.com/)<br />[📖](https://github.com/jfmengels/all-contributors-cli/commits?author=kentcdodds) | [<img src="https://avatars.githubusercontent.com/u/14871650?v=3" width="100px;"/><br /><sub>João Guimarães</sub>](https://github.com/jccguimaraes)<br />[💻](https://github.com/jfmengels/all-contributors-cli/commits?author=jccguimaraes) | [<img src="https://avatars.githubusercontent.com/u/1282980?v=3" width="100px;"/><br /><sub>Ben Briggs</sub>](http://beneb.info)<br />[💻](https://github.com/jfmengels/all-contributors-cli/commits?author=ben-eb) | | |||
| | :---: | :---: | :---: | :---: | | |||
| | [<img src="https://avatars.githubusercontent.com/u/3869412?v=3" width="100px;"/><br /><sub>Jeroen Engels</sub>](https://github.com/jfmengels)<br />[💻](https://github.com/jfmengels/all-contributors-cli/commits?author=jfmengels) [📖](https://github.com/jfmengels/all-contributors-cli/commits?author=jfmengels) [⚠️](https://github.com/jfmengels/all-contributors-cli/commits?author=jfmengels) | [<img src="https://avatars.githubusercontent.com/u/1500684?v=3" width="100px;"/><br /><sub>Kent C. Dodds</sub>](http://kentcdodds.com/)<br />[📖](https://github.com/jfmengels/all-contributors-cli/commits?author=kentcdodds) | [<img src="https://avatars.githubusercontent.com/u/14871650?v=3" width="100px;"/><br /><sub>João Guimarães</sub>](https://github.com/jccguimaraes)<br />[💻](https://github.com/jfmengels/all-contributors-cli/commits?author=jccguimaraes) | [<img src="https://avatars.githubusercontent.com/u/1282980?v=3" width="100px;"/><br /><sub>Ben Briggs</sub>](http://beneb.info)<br />[💻](https://github.com/jfmengels/all-contributors-cli/commits?author=ben-eb) | [<img src="https://avatars.githubusercontent.com/u/22768990?v=3" width="100px;"/><br /><sub>Itai Steinherz</sub>](https://github.com/itaisteinherz)<br />[📖](https://github.com/jfmengels/all-contributors-cli/commits?author=itaisteinherz) [💻](https://github.com/jfmengels/all-contributors-cli/commits?author=itaisteinherz) | | |||
There was a problem hiding this comment.
I think the contributors list got duplicated because of 92e2aa2.
|
I was hoping that I wouldn't have to actually pull it down (I'm so impressed with how much GitHub's web client is capable of these days!) but I got the formatting wrong on the table :face_palm: so I've pulled it down and regenerated things :) Should be good now I think. Will let @jfmengels merge and release if he thinks it's ready. |
|
Thanks to you both! By the way, I just gave you publishing rights, I trust your judgement in handling this tool, you use it more than I do 😄 |
|
Do you mind if I setup semantic-release on it? |
|
No I don't, but I have never learnt how to use it (or rather, what the commit messages should look like). I guess it's time to do so :D |
|
Luckily with GitHub's new "Rebase and Merge" functionality, you can change the commit message of PRs when you merge them right in GitHub's UI which is pretty amazingly awesome. I'll get things setup. Thanks! |
To "upgrade" to the latest specification.
I'm not sure whether to consider this a breaking change...