Add new contribution types to README.md #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the new contribution types to accommodate #24.
|
Awesome! Thanks for the contribution! I'll hopefully take some time today to fix #24 so we can merge both of these :) |
|
@kentcdodds Thanks! I also created #27 to fix the failing tests. |
jfmengels
pushed a commit
that referenced
this pull request
Jan 25, 2017
* feat(types): add/update contrib types To "upgrade" to the latest specification. * fix: linting issues * test: Update question emoji in tests (#27) * Update format-contribution-type.test.js Updated the expected question emoji. * Update format-contributor.test.js Updated the expected question emoji. * Add @itaisteinherz as a contributor * generate * add code * doc: Add new contribution types to README.md (#26) * Update README.md Added the new contribution types to accommodate #24. * Add @itaisteinherz as a contributor * regenerate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the new contribution types to accommodate #24.