Modern cleanup #2
Open
+146
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the deprecated Buffer constructor calls and replaced with `Buffer.from()` and `Buffer.alloc()` Removed unused `toBinaryString` from buffer-tools Changed from cipher algorithm alias to real names (`aes128`, `aes192`, and `aes256` to `aes-128-cbc`, `aes-192-cbc`, and `aes-256-cbc`) to improve compatibility with Electron, see electron/electron#16195 for more details Now allows users to provide their own cipher algorithm name. To keep backwards compatibility, if an algorithm is not given then defaults to the old lookup table method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the deprecated Buffer constructor calls and replaced with
Buffer.from()andBuffer.alloc()Removed unused
toBinaryStringfrom buffer-toolsChanged from cipher algorithm alias to real names (
aes128,aes192, andaes256toaes-128-cbc,aes-192-cbc, andaes-256-cbc) to improve compatibility with Electron, see electron/electron#16195 for more detailsNow allows users to provide their own cipher algorithm name. To keep backwards compatibility, if an algorithm is not given then defaults to the old lookup table method
Condensed getMessageBlock and getPaddedMessageBlock into one function to remove duplicate code
And finally just some general changes to make things a bit more modern/readable