Move getOldestEntry to test file #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janisz
force-pushed
the
move_test_function
branch
from
1a7f98b
to
05f95d7
Compare
siennathesane
approved these changes
Jan 9, 2020
cristaloleg
reviewed
Jan 9, 2020
@cristaloleg would you be able to clarify what you mean by that? Are you saying that the whole lifecycle of this PR was too fast? It was a simple change and all the tests passed, so I didn't see a reason to wait on it since I was already looking at it. |
|
@mxplusb No, everything is ok, just I'm trying to reduce amount of closures inside hot path when it's possible. AFAIR they're not inlined at all, which is a bit uncool for us. |
|
Gotcha, that makes sense. It's part of the test so I'm less concerned in this specific base, but I do agree that closures should be used carefully. |
flisky
pushed a commit
to flisky/bigcache
that referenced
this pull request
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
getOldestEntryfrom production code to test where it's used.