Remove maxShardSize from BigCache
#294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Penthaa Patel <penthaapatel@gmail.com>
penthaapatel
changed the title
maxShardSize from BigCache
janisz
previously approved these changes
Oct 28, 2021
|
@janisz I saw the tests were failing, I had to lint the code so pushed another change. Hope it's good to go now. |
janisz
approved these changes
Oct 28, 2021
Codecov Report
@@ Coverage Diff @@
## master #294 +/- ##
==========================================
- Coverage 88.99% 88.97% -0.02%
==========================================
Files 15 15
Lines 763 762 -1
==========================================
- Hits 679 678 -1
Misses 70 70
Partials 14 14
Continue to review full report at Codecov.
|
cristaloleg
approved these changes
Oct 29, 2021
|
@penthaapatel Thanks 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #293