Skip to content

Commit

Permalink
Fix property name for 0.13.1 (#902)
Browse files Browse the repository at this point in the history
  • Loading branch information
cristaloleg committed Aug 30, 2018
1 parent c36f913 commit f89c830
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
11 changes: 9 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
## 0.13.1 (30.08.2018)

Small fix in config.properties.

Property `messages.local.buffered.storage.size.bytes` from 0.13.0 now becomes
`frontend.messages.local.buffered.storage.size.bytes`.

## 0.13.0 (28.08.2018)

All issues and pull requests: [0.13.0 milestone](https://github.com/allegro/hermes/milestone/48)
Expand All @@ -10,13 +17,13 @@ Starting from this version Hermes will use [ChronicleMap v3](https://github.com/
buffer for messages (before that Hermes was using ChronicleMap v2).

Now there are 2 new config properties:
- `messages.local.buffered.storage.size.bytes` - describes default size for a delayed messages queue in bytes
- `frontend.messages.local.buffered.storage.size.bytes` - describes default size for a delayed messages queue in bytes
in internal Kafka Producer Queue and Hermes Frontend Buffer.

- `frontend.messages.local.storage.average.message.size.in.bytes` - describes average message size for better performance
for delayed messages in Hermes Frontend Buffer.

And also `kafka.producer.buffer.memory` was removed from a config, now `messages.local.buffered.storage.size.bytes`
And also `kafka.producer.buffer.memory` was removed from a config, now `frontend.messages.local.buffered.storage.size.bytes`
is responsible for that parameter.


Expand Down
2 changes: 1 addition & 1 deletion hermes-benchmark/src/jmh/resources/config.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ schema.repository.type=zookeeper
schema.cache.enabled=false
frontend.messages.local.storage.enabled=true
metrics.zookeeper.reporter=false
messages.local.buffered.storage.size.bytes=5242880 // 5mb
frontend.messages.local.buffered.storage.size.bytes=5242880 // 5mb
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,7 @@ public enum Configs {
FRONTEND_STARTUP_TOPIC_SCHEMA_LOADING_RETRY_COUNT("frontend.startup.topic.schema.loading.retry.count", 3),
FRONTEND_STARTUP_TOPIC_SCHEMA_LOADING_THREAD_POOL_SIZE("frontend.startup.topic.schema.loading.thread.pool.size", 16),

MESSAGES_LOCAL_BUFFERED_STORAGE_SIZE("messages.local.buffered.storage.size.bytes", 256 * 1024 * 1024L),

MESSAGES_LOCAL_BUFFERED_STORAGE_SIZE("frontend.messages.local.buffered.storage.size.bytes", 256 * 1024 * 1024L),
MESSAGES_LOCAL_STORAGE_V2_MIGRATION_ENABLED("frontend.messages.local.storage.v2.migration.enabled", true),
MESSAGES_LOCAL_STORAGE_ENABLED("frontend.messages.local.storage.enabled", false),
MESSAGES_LOCAL_STORAGE_DIRECTORY("frontend.messages.local.storage.directory", Files.createTempDir().getAbsolutePath()),
Expand Down

0 comments on commit f89c830

Please sign in to comment.