Improved handling unavailable metrics #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dankraw
reviewed
May 28, 2019
| return UNAVAILABLE; | ||
| } | ||
|
|
||
| public static MetricLongValue of(long lag) { |
druminski
approved these changes
May 28, 2019
cristaloleg
approved these changes
May 28, 2019
| this.value = value; | ||
| } | ||
|
|
||
| public static MetricDecimalValue unavailable() { |
There was a problem hiding this comment.
Why we cannot make UNAVAILABLE as a public field and just use it?
There was a problem hiding this comment.
In my opinion unavailable() is better in this case because it is consistent with other factory method - of(...).
| private static final String UNAVAILABLE_STRING = "unavailable"; | ||
| private static final MetricDecimalValue UNAVAILABLE = new MetricDecimalValue(true, "-1.0"); | ||
|
|
||
| private final boolean unavailable; |
There was a problem hiding this comment.
Storing non-negated field might be more readable, wdyt?
dankraw
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #989