Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto switching to read only mode #1052 #1056

Merged
merged 13 commits into from
Jul 5, 2019
Merged

Auto switching to read only mode #1052 #1056

merged 13 commits into from
Jul 5, 2019

Conversation

jewertow
Copy link
Contributor

@jewertow jewertow commented Jul 3, 2019

No description provided.

piotrrzysko
piotrrzysko reviewed Jul 3, 2019
View reviewed changes
...ment/src/main/java/pl/allegro/tech/hermes/management/domain/health/HealthCheckScheduler.java Outdated Show resolved Hide resolved
...nagement/src/main/java/pl/allegro/tech/hermes/management/domain/health/NodeDataProvider.java
import java.net.UnknownHostException;

@Component
class NodeDataProvider {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have something similar: https://github.com/allegro/hermes/blob/master/hermes-common/src/main/java/pl/allegro/tech/hermes/common/util/InetAddressHostnameResolver.java. Maybe you can merge those two implementations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will not change it.

...anagement/src/main/java/pl/allegro/tech/hermes/management/domain/health/HealthCheckTask.java Outdated Show resolved Hide resolved
@cristaloleg
Copy link
Contributor

Looks like you need to rebase your changes on the latest master
https://travis-ci.org/allegro/hermes/jobs/553657581#L626

dankraw
dankraw reviewed Jul 4, 2019
View reviewed changes
...anagement/src/main/java/pl/allegro/tech/hermes/management/domain/health/HealthCheckTask.java Outdated
}
}

enum HealthCheckResult {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private?

cristaloleg
cristaloleg reviewed Jul 4, 2019
View reviewed changes
Copy link
Contributor

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jewertow jewertow merged commit 51185b3 into master Jul 5, 2019
@dankraw
Copy link
Contributor

dankraw commented Jul 5, 2019

squashed as 255680d

@druminski druminski mentioned this pull request Jul 12, 2019
Closed
@cristaloleg cristaloleg deleted the auto-switching-to-read-only-mode-1052-2 branch July 29, 2019 10:36
@piotrrzysko piotrrzysko mentioned this pull request Jun 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrrzysko piotrrzysko piotrrzysko left review comments

@cristaloleg cristaloleg cristaloleg approved these changes

@dankraw dankraw dankraw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jewertow @cristaloleg @dankraw @piotrrzysko