Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read only mode set by admin should not be overwritten #1211

Closed
piotrrzysko opened this issue Jun 8, 2020 · 0 comments
Closed

Read only mode set by admin should not be overwritten #1211

piotrrzysko opened this issue Jun 8, 2020 · 0 comments
Assignees
@milenakrawczyk

Comments

@piotrrzysko
Copy link
Member

We would like to avoid situation when RO mode for hermes-management set by admin (#1025) is overwritten by background job responsible for checking ZK health (#1056).
milenakrawczyk pushed a commit that referenced this issue Jun 9, 2020
Resolve #1211 | Read only admin flag added to Mode Service
fbd3949
milenakrawczyk pushed a commit that referenced this issue Jun 10, 2020
Resolve #1211 | Tests added for READ_ONLY_ADMIN flag
23ebfaa
milenakrawczyk pushed a commit that referenced this issue Jun 10, 2020
Resolve #1211 | Thread-safe version
d54d18a
milenakrawczyk pushed a commit that referenced this issue Jun 15, 2020
Resolve #1211 | Changes after code review; admin endpoint accepts Rea…
002db3d 
…dOnlyAdmin flag as well
pwolaq pushed a commit to pwolaq/hermes that referenced this issue Oct 15, 2020
@milenakrawczyk @pwolaq
Resolve allegro#1211 | Read only mode persistence (allegro#1214)
ebded90 
* Resolve allegro#1211 | Read only admin flag added to Mode Service

* Resolve allegro#1211 | Tests added for READ_ONLY_ADMIN flag

* Resolve allegro#1211 | Thread-safe version

* Resolve allegro#1211 | Changes after code review; admin endpoint accepts ReadOnlyAdmin flag as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milenakrawczyk milenakrawczyk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@piotrrzysko @milenakrawczyk