Resolve #1211 | Read only mode persistence #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
druminski
previously approved these changes
Jun 10, 2020
jewertow
reviewed
Jun 14, 2020
There was a problem hiding this comment.
Reading the test "should change status from READ_ONLY_ADMIN to READ_WRITE only by admin" I came to the conclusion that the api exposed by ModeService is not obvious. Let's suppose we have to add another component responsible for changing the mode. It will be not obvious why should I call compareAndSwapMode instead of setMode. It will be necessary to read the implementation and tests to understand the consequences of using setMode. So I suggest to change these methods:
setMode->setModeByAdmin(expectedMode)- set modecompareAndSwapMode->setMode(expectedMode)- set mode if current mode is not equal toREAD_ONLY_ADMIN.
What do you think?
Anyway, I tested this PR locally with 2 ZK clusters and it works correctly.
...t/src/test/groovy/pl/allegro/tech/hermes/management/domain/health/HealthCheckTaskTest.groovy
Outdated
Show resolved
Hide resolved
...t/src/test/groovy/pl/allegro/tech/hermes/management/domain/health/HealthCheckTaskTest.groovy
Outdated
Show resolved
Hide resolved
…dOnlyAdmin flag as well
milenakrawczyk
dismissed stale reviews from cristaloleg and druminski
via
002db3d
cristaloleg
approved these changes
Jun 15, 2020
jewertow
approved these changes
Jun 15, 2020
pwolaq
pushed a commit
to pwolaq/hermes
that referenced
this pull request
Oct 15, 2020
* Resolve allegro#1211 | Read only admin flag added to Mode Service * Resolve allegro#1211 | Tests added for READ_ONLY_ADMIN flag * Resolve allegro#1211 | Thread-safe version * Resolve allegro#1211 | Changes after code review; admin endpoint accepts ReadOnlyAdmin flag as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read only mode set by admin (READ_ONLY_ADMIN) in hermes management is not overwritten by healthcheck task.