Added UI panel for http header filters #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrrzysko
reviewed
Jun 7, 2021
| @@ -20,7 +21,8 @@ | |||
| FilterChainFactory filterChainFactory() { | |||
| List<SubscriptionMessageFilterCompiler> subscriptionFilterCompilers = Arrays.asList( | |||
| new AvroPathSubscriptionMessageFilterCompiler(), | |||
| new JsonPathSubscriptionMessageFilterCompiler() | |||
| new JsonPathSubscriptionMessageFilterCompiler(), | |||
| new HeaderSubscriptionMessageFilterCompiler() | |||
There was a problem hiding this comment.
As far as I remember, hermes-management is aware of the filters only because it has a logic related to the filters debugger. As the debugger doesn't currently support header filters, I think this change is not needed.
There was a problem hiding this comment.
You are right, this change is not needed. However I added it to simplify adding support for headers dubbuger in the future. Thanks to this line only changes on frontend side are needed now and next developer doesn't have to analyze backend side at all.
piotrrzysko
approved these changes
Jun 7, 2021
faderskd
approved these changes
Jun 7, 2021
| @@ -29,8 +29,9 @@ console: | |||
| label: DAYS | |||
| subscription: | |||
| showHeadersFilter: true | |||
| showFixedHeaders: false | |||
There was a problem hiding this comment.
This should also be added to ConsoleProperties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Http header filterpanel in subscription view. The panel is displayed belowFilterpanel as in the attached image. By defaultHttp header panelis disabled. It can be enabled byshowHeadersFilterflag in Hermes console config. At the moment the panel dosen't supportDebugmode andmatching strategy, but they can be added in the future.