Configurable request timeout in subscription view. #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eobrusnik
previously approved these changes
Jul 13, 2021
Kornelos
previously approved these changes
Jul 13, 2021
…efault value to 'false' for store offline property in topic view.
druminski
force-pushed
the
subscription-timeout-in-ui
branch
from
77ac981
to
f9ec23e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes Http client request timeout in subscription view of Hermes UI. It also displays warning when request timeout is set to a bigger value.
Additionally, the PR changes default value of
store offlineproperty on topic view tofalse.This PR is a continuation of #1327 by @tadamcze, thanks for the contribution :)