Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary logging. #225

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Remove unnecessary logging. #225

merged 1 commit into from
Apr 7, 2017

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Apr 7, 2017

Error is returned so there is no need to log it. It should be done by caller.

@janisz janisz requested a review from wendigo April 7, 2017 14:42
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 87.54% when pulling 219d49e on remove_uncecessary_loggoing into 888b8e9 on master.

@janisz janisz merged commit f987722 into master Apr 7, 2017
@janisz janisz deleted the remove_uncecessary_loggoing branch April 7, 2017 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dankraw dankraw dankraw approved these changes

@wendigo wendigo Awaiting requested review from wendigo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@janisz @coveralls @dankraw @adamdubiel