Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move defer out of function body. #259

Merged
merged 1 commit into from
Aug 4, 2017
Merged

Move defer out of function body. #259

merged 1 commit into from
Aug 4, 2017

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Aug 4, 2017

After sse.NewHandler was moved to fucntion, defer was
called everytime handler was created not just before exiting main.

@janisz
Move defer out of function body.
bf3bf49 
After `sse.NewHandler` was moved to fucntion, `defer` was
called everytime handler was created not just before exiting `main`.
@janisz janisz requested a review from tomez August 4, 2017 10:42
@janisz janisz merged commit 7566270 into master Aug 4, 2017
@janisz janisz deleted the hotfix/defer_called_every_time branch August 4, 2017 10:49
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.066% when pulling bf3bf49 on hotfix/defer_called_every_time into e108886 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomez tomez tomez approved these changes

@dankraw dankraw dankraw approved these changes

@adamdubiel adamdubiel adamdubiel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@janisz @coveralls @tomez @dankraw @adamdubiel