Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving port placeholders in Marathon labels #292

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Resolving port placeholders in Marathon labels #292

merged 1 commit into from
Jul 15, 2019

Conversation

pbetkier
Copy link
Contributor

Adds a feature of port placeholders in Marathon labels that are resolved in consul tags when registering a service.

Placeholders format: {port:<port name>}, where <port name> should be a name of an existing port definitions. Such placeholder will be replaced by related port number when mapping Marathon labels into Consul tags.

@coveralls
Copy link

coveralls commented Jul 12, 2019

Coverage Status

Coverage increased (+0.1%) to 90.818% when pulling e807685 on pbetkier:port_placeholders_in_labels into d65e3da on allegro:master.

@MarcinFalkowski MarcinFalkowski self-requested a review July 12, 2019 09:23
@pbetkier pbetkier merged commit cd4ef1c into allegro:master Jul 15, 2019
@pbetkier pbetkier mentioned this pull request Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants