Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VaaS registration regression #97

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Fix VaaS registration regression #97

merged 1 commit into from
Mar 20, 2018

Conversation

tomez
Copy link
Contributor

@tomez tomez commented Mar 16, 2018 •
edited
Loading

When VaaS registration request was unsuccessful, executor crashed.
This happened because *sh.backendID was nil pointer when referenced, it
turned out, it is set only after correct response from server.

@coveralls
Copy link

coveralls commented Mar 16, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 73.038% when pulling d194c50 on regression_fix into 476ae4d on master.

janisz
janisz suggested changes Mar 16, 2018
View reviewed changes
hook/vaas/hook_test.go Outdated
@@ -13,6 +13,7 @@ import (
"github.com/allegro/mesos-executor/hook"
"github.com/allegro/mesos-executor/mesosutils"
"github.com/allegro/mesos-executor/runenv"
"fmt"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goimports

medzin
medzin suggested changes Mar 20, 2018
View reviewed changes
Copy link
Contributor

@medzin medzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a description (in commit message) of what the error is and how it is fixed. I understand that the idea is that the backend ID is not set when we have API error?

@tomez
Fix regression
d194c50 
When VaaS registration request was unsuccessful, executor crashed.
This happened because *sh.backendID was nil pointer when referenced, it
turned out,it is set only after correct response from server.
@tomez tomez merged commit 36bedd2 into master Mar 20, 2018
@medzin medzin deleted the regression_fix branch April 27, 2018 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medzin medzin medzin approved these changes

@janisz janisz janisz approved these changes

@AlfredBroda AlfredBroda Awaiting requested review from AlfredBroda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomez @coveralls @medzin @janisz